Should we change \rho attribute after put?

[maxonfjvipon]

We have a EO code:

[] > scope
  [x] > inner
    x > @
  5 > five
  inner five > applied

I suppose that:

• five.^ refer to scope
• inner.^ refer to scope
• applied.^ refer to scope

These all \rho's refer to scope because all these objects are bound But what about applied.x.^. What it supposed to refer to? I think it should refer to applied, it seems logical to me, but I'm not sure. Anyway in current Java implementation applied.x.^ does not refer to applied, it refers to scope.

This test passes:

public class Foo extends PhDefault {
    Foo(final Phi sigma) {
        super(sigma);
        this.add("x", new AtFree());
    }
}
.....
@Test
void tests() {
    Phi num = new Data.ToPhi(10L);
    Phi foo = new Foo(Phi.Φ);
    foo.attr("x").put(num);
    MatcherAssert.assertThat(
        foo.hashCode(),
        Matchers.not(
            Matchers.equalTo(foo.attr("x").get().attr("ρ").get().hashCode())
        )
    );
}

@yegor256 WDYT?

[yegor256]

@maxonfjvipon most probably it's a bug, you are right. We reset \rho here and here, but we don't do it for all other attributes. I believe, we should, in a new else block after this line.

[maxonfjvipon]

@yegor256 about these two places where we replaced \rho: we replace it after we get() the attribute through \phi or \lambda which seems a bit strange:

[] > animal
  "Hello" > say
[] > cat
  animal > @

cat.@.say.^ # refers to animal
cat.say.^   # refers to cat because we replaced \rho
cat.@.say.^ # now refers to cat because we replaced \rho above

Correct me if I'm wrong

UPD: this test confirms it:

static class Animal extends PhDefault {
    Animal() {
        super(Phi.Φ);
        this.add("say", new AtOnce(new AtComposite(this, rho -> {
            Phi phi = new Data.ToPhi("Hello");
            phi.attr("ρ").put(rho);
            return phi;
        })));
    }
}

static class Cat extends PhDefault {
    Cat(Phi animal) {
        super(Phi.Φ);
        this.add(Attr.PHI, new AtSimple(animal));
    }
}

@Test
void other() {
    Phi animal = new Animal();
    Phi cat = new Cat(animal);
    System.out.println("animal");
    System.out.println(animal.hashCode());
    System.out.println("animal.say.^");
    System.out.println(animal.attr("say").get().attr("ρ").get().hashCode());
    System.out.println("cat.@.say.^");
    System.out.println(cat.attr(Attr.PHI).get().attr("say").get().attr("ρ").get().hashCode());
    System.out.println("cat.say.^");
    System.out.println(cat.attr("say").get().attr("ρ").get().hashCode());
    System.out.println("cat.@.say.^");
    System.out.println(cat.attr(Attr.PHI).get().attr("say").get().attr("ρ").get().hashCode());
}

The output is confusing:

[maxonfjvipon]

This rule from phi paper shows that when we retrieve attribute from the object, we should make a copy of given object and change \rho (copying is the part of application process):

Meantime this rule shows that when we retrieve attribute through \phi, we should just retrieve it from the object attached to \phi.

Combination of this two rules shows that we have two problems in our current java implementation:

1. We must not reset \rho when we retrieve attribute through \phi or \lambda here and here
2. When we retrieve attribute from the object, we should make a copy of given object and change \rho to this; which we're not doing.

The only thing I'm not sure about: every attribute retrieval leads to creating new object:

int.plus > plus1
int.plus > plus2

These plus1 and plus2 are different objects. Is it okay?

@yegor256 WDYT?

[yegor256]

@maxonfjvipon yes, they should be two different objects

[maxonfjvipon]

@yegor256 I guess this rule should not be applied when \tau1 is \rho or \sigma?

[maxonfjvipon]

Update:

1. Changing \rho while dispatch is not working. Why:

   [] > x
   1.plus 2 > three

   When x.three will be dataized - new \rho attached to x is injected. But x.three refers to 1.plus 2 which means that (1.plus 2).^ is changed. But int.plus object uses \rho for dataization. When it was 1, 1.plus 2 worked, but when we changed it to x, but does not work anymore, plus lost information about original \rho which was 1.

2. When object is created for the first time (formatted) it should not have \rho

3. \rho should be immutable. It should be set only once while application (copying) process. If we're trying to copy object with already set \rho - it should not be changed

   
   [delta] > int
   [] > plus

int.^ # error, rho is absent

int 5 > int1 int1.^ # refers to global phi object

int1.plus.^ # refers to int1 int1' > int2 int2.plus.^ # refers to int1 int1.plus != int2.plus # different objects

@yegor256 please correct me, if I'm wrong

[0pdd]

@maxonfjvipon 17 puzzles #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2978, #2979, #2980, #2981 are still not solved.

[0pdd]

@maxonfjvipon 14 puzzles #2965, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2978, #2979, #2981 are still not solved; solved: #2966, #2967, #2980.

[0pdd]

@maxonfjvipon 12 puzzles #2965, #2968, #2970, #2971, #2972, #2973, #2974, #2976, #2977, #2978, #2979, #2981 are still not solved; solved: #2966, #2967, #2969, #2975, #2980.

[0pdd]

@maxonfjvipon 11 puzzles #2965, #2968, #2970, #2971, #2972, #2973, #2976, #2977, #2978, #2979, #2981 are still not solved; solved: #2966, #2967, #2969, #2974, #2975, #2980.

[0pdd]

@maxonfjvipon 10 puzzles #2965, #2968, #2970, #2971, #2972, #2976, #2977, #2978, #2979, #2981 are still not solved; solved: #2966, #2967, #2969, #2973, #2974, #2975, #2980.

[0pdd]

@maxonfjvipon 9 puzzles #2965, #2968, #2970, #2971, #2972, #2977, #2978, #2979, #2981 are still not solved; solved: #2966, #2967, #2969, #2973, #2974, #2975, #2976, #2980.

[0pdd]

@maxonfjvipon 19 puzzles #2965, #2970, #2977, #2978, #2979, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015 are still not solved; solved: #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2980, #2981, #2999.

[0pdd]

@maxonfjvipon 17 puzzles #2965, #2970, #2977, #2978, #2979, #3001, #3002, #3004, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015 are still not solved; solved: #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2980, #2981, #2999, #3000, #3005.

[0pdd]

@maxonfjvipon 15 puzzles #2965, #2970, #2978, #2979, #3001, #3002, #3004, #3006, #3008, #3009, #3010, #3011, #3013, #3015, #3021 are still not solved; solved: #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3005, #3007, #3012.

[0pdd]

@maxonfjvipon 14 puzzles #2965, #2970, #2978, #2979, #3001, #3002, #3004, #3006, #3008, #3009, #3010, #3011, #3015, #3021 are still not solved; solved: #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3005, #3007, #3012, #3013.

[0pdd]

@maxonfjvipon 13 puzzles #2965, #2970, #2978, #2979, #3001, #3002, #3004, #3006, #3008, #3009, #3011, #3015, #3021 are still not solved; solved: #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3005, #3007, #3010, #3012, #3013.

[0pdd]

@maxonfjvipon 12 puzzles #2970, #2978, #2979, #3001, #3002, #3004, #3006, #3008, #3009, #3011, #3015, #3021 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3005, #3007, #3010, #3012, #3013.

[0pdd]

@maxonfjvipon 11 puzzles #2970, #2978, #2979, #3001, #3002, #3004, #3006, #3008, #3009, #3015, #3021 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3005, #3007, #3010, #3011, #3012, #3013.

[0pdd]

@maxonfjvipon 10 puzzles #2970, #2978, #2979, #3001, #3002, #3004, #3006, #3008, #3015, #3021 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3005, #3007, #3009, #3010, #3011, #3012, #3013.

[0pdd]

@maxonfjvipon 9 puzzles #2970, #2978, #2979, #3001, #3002, #3006, #3008, #3015, #3021 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3004, #3005, #3007, #3009, #3010, #3011, #3012, #3013.

[maxonfjvipon]

Given result:

1. Every object does not have \rho when it's formed
2. \rho is immutable and set when object is dispatched (if \rho was not set before). When attribute is dispatched through decoratee @, the \rho is set to the object, that starts retrieval.

   [] > x 
   [] > @
   [] > z # \rho is absent
   [] > y # \rho is absent
   x.y > xy # xy.^ -> x
   x.z > xz # xz.^ -> x

[0pdd]

@maxonfjvipon 8 puzzles #2978, #2979, #3001, #3002, #3006, #3008, #3015, #3021 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3004, #3005, #3007, #3009, #3010, #3011, #3012, #3013.

[0pdd]

@maxonfjvipon 6 puzzles #2978, #2979, #3002, #3006, #3008, #3015 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3004, #3005, #3007, #3009, #3010, #3011, #3012, #3013, #3021.

[0pdd]

@maxonfjvipon 5 puzzles #2978, #2979, #3008, #3015, #3055 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3009, #3010, #3011, #3012, #3013, #3021.

[0pdd]

@maxonfjvipon 4 puzzles #2978, #2979, #3008, #3015 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3009, #3010, #3011, #3012, #3013, #3021, #3055.

[0pdd]

@maxonfjvipon 3 puzzles #2978, #2979, #3015 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3021, #3055.

[0pdd]

@maxonfjvipon 2 puzzles #2978, #2979 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015, #3021, #3055.

[0pdd]

@maxonfjvipon 4 puzzles #2978, #2979, #3067, #3068 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015, #3021, #3055.

[0pdd]

@maxonfjvipon 3 puzzles #2978, #2979, #3067 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015, #3021, #3055, #3068.

[0pdd]

@maxonfjvipon 2 puzzles #2979, #3067 are still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2978, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015, #3021, #3055, #3068.

[0pdd]

@maxonfjvipon the puzzle #3067 is still not solved; solved: #2965, #2966, #2967, #2968, #2969, #2970, #2971, #2972, #2973, #2974, #2975, #2976, #2977, #2978, #2979, #2980, #2981, #2999, #3000, #3001, #3002, #3004, #3005, #3006, #3007, #3008, #3009, #3010, #3011, #3012, #3013, #3015, #3021, #3055, #3068.