Closed maxonfjvipon closed 3 months ago
@yegor256 please check
@yegor256 about stdout
in EO tests. To print to console we use system call now. It means that we skip java System.out
and writes data directly to operating system standard output (which is only one in whole operating system). To test that data is written successfully and objects work I redicrect standard output to temporary file. Since all our test run in parallel - there are may be collisions when output is redirected and two tests write to redirected output which leads to unexpected data written to output - test is failed. That's why all stdout
occurrences are removed from EO tests and java tests from InputOutputTest
class run in one thread
@yegor256 please check one more time
@rultor merge
@rultor merge
@yegor256 OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@yegor256 Done! FYI, the full log is here (took me 31min)
@yegor256 Thanks for your code review! You've earned +70 points for this contribution: +15 as a base reward; +30 for the substantial 3024 hits-of-code reviewed; -10 for having fewer than 6 comments; +5 for the 5 comments you made. We appreciate your effort, but please aim for more thorough reviews with at least 6 comments in the future. Your updated balance is now +228. Keep up the good work and remember that detailed feedback helps improve our code quality!
Ref: #3251
What's done:
console.write
object is implemented in pure EO via syscallsFileWrite
function call is implementedstdout
occurrences are removed from EO tests so there are no conflicts with outputs redirectingPR-Codex overview
This PR removes unnecessary test files, updates test cases, refactors package aliases, and improves error handling in various EO language modules.
Detailed summary