Closed volodya-lombrozo closed 5 days ago
@rultor merge
@rultor merge
@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here
@rultor merge
@volodya-lombrozo Done! FYI, the full log is here (took me 32min)
@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (1125 >= 200); -16 for way too many hits-of-code (1125 >= 800); -16 for the lack of code review; -4 for very few (2) comments; +44 to give you at least something. Please, keep them coming. Your running balance is +96.
In this PR I successfully simplified the usage of
JeoFqn
andEoFqn
objects. Now we create them only in rare cases in a few objects. To reduce duplication amongDirectives*
classes I addedDirectivesEoObject
,DirectivesJeoObject
,DirectivesAbstractObject
. Exactely these clases useJeoFqn
andEoFqn
.Closes: #714. History:
PR-Codex overview
This PR focuses on refactoring the
Directives
classes in the EO language representation by modifying constructors, enhancing object-oriented design, and improving the clarity of directive creation.Detailed summary
public
toprivate
.DirectivesProgram
,DirectivesClass
, and others.withClass
andwithMethod
methods with direct constructor usage.DirectivesAbstractObject
andDirectivesEoObject
classes for better abstraction.iterator
methods to use new directive object structures.DirectivesTryCatch
.DirectivesValue
constructors for consistency.