objectionary / jeo-maven-plugin

This Maven plugin converts Java Bytecode binary files to EOLANG programs that use the "opcode" atom
https://www.objectionary.com/jeo-maven-plugin/
MIT License
11 stars 3 forks source link

feat(#714): Simplify JeoFqn and EoFqn Objects Usage #740

Closed volodya-lombrozo closed 5 days ago

volodya-lombrozo commented 5 days ago

In this PR I successfully simplified the usage of JeoFqn and EoFqn objects. Now we create them only in rare cases in a few objects. To reduce duplication among Directives* classes I added DirectivesEoObject, DirectivesJeoObject, DirectivesAbstractObject. Exactely these clases use JeoFqn and EoFqn.

Closes: #714. History:


PR-Codex overview

This PR focuses on refactoring the Directives classes in the EO language representation by modifying constructors, enhancing object-oriented design, and improving the clarity of directive creation.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

volodya-lombrozo commented 5 days ago

@rultor merge

rultor commented 5 days ago

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here

rultor commented 5 days ago

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 32min)

0crat commented 4 days ago

@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +4 as a basis; -8 for too many hits-of-code (1125 >= 200); -16 for way too many hits-of-code (1125 >= 800); -16 for the lack of code review; -4 for very few (2) comments; +44 to give you at least something. Please, keep them coming. Your running balance is +96.