objectionary / jeo-maven-plugin

This Maven plugin converts Java Bytecode binary files to EOLANG programs that use the "opcode" atom
https://www.objectionary.com/jeo-maven-plugin/
MIT License
11 stars 3 forks source link

`opcode` objects in XMIR don't have supplementary comments #849

Closed yegor256 closed 3 days ago

yegor256 commented 1 week ago

After #847

I see this:

<o base="org.eolang.jeo.opcode"
   line="71974242"
   name="invokespecial-16">
   <o base="org.eolang.jeo.int">
      <o base="bytes" data="bytes">00 00 00 00 00 00 00 B7</o>
   </o>
   <o base="org.eolang.jeo.string">
      <o base="bytes" data="bytes">6A 61 76 61 2F 6C 61 6E 67 2F 4F 62 6A 65 63 74</o>
   </o>
   <o base="org.eolang.jeo.string">
      <o base="bytes" data="bytes">3C 69 6E 69 74 3E</o>
   </o>
   <o base="org.eolang.jeo.string">
      <o base="bytes" data="bytes">28 29 56</o>
   </o>
   <o base="org.eolang.jeo.bool">
      <o base="bytes" data="bytes">00</o>
   </o>
</o>

Would be much more readable, if I would see this comment too:

<o base="org.eolang.jeo.opcode"
   line="71974242"
   name="invokespecial-16">
   <!-- INVOKESPECIAL 183, "java/lang/Object", "<init>", "()V", FALSE -->
   <o base="org.eolang.jeo.int">
      <o base="bytes" data="bytes">00 00 00 00 00 00 00 B7</o>
   </o>
   [...]
</o>
yegor256 commented 1 week ago

@volodya-lombrozo please, check

volodya-lombrozo commented 5 days ago

@yegor256 could you check comments in the new version, please? They should appear in the generated xmir.

yegor256 commented 5 days ago

@volodya-lombrozo everywhere when I see comments, they look like this:

<!--177-->

Would be better to make them look like this:

<!-- 177 -->
volodya-lombrozo commented 4 days ago

@rultor release, tag is 0.6.19, title is 0.6.19

rultor commented 4 days ago

@rultor release, tag is 0.6.19, title is 0.6.19

@volodya-lombrozo OK, I will release it now. Please check the progress here.

rultor commented 4 days ago

@rultor release, tag is 0.6.19, title is 0.6.19

@volodya-lombrozo Done! FYI, the full log is here (took me 13min).