Closed Anatolay closed 1 month ago
@Anatolay It is not a good idea to name Git branches the way you named this one: "unit-tests
". You've earned -10 points. Next time, better give your branch the same name as the number of the ticket that you are solving. In this case, a perfect name, for example, would be "460
". Your running balance is +5.
@Anatolay, #36 required 5 unit tests for each rule. Please add more unit tests
@Anatolay, #36 required 5 unit tests for each rule. Please add more unit tests
Wasn't it discussed that 2-3 per rule should be enough?
@Anatolay, it was discussed, but not agreed.
@Anatolay, it was agreed to write at least 3 tests.
Let's merge this, and follow up with more unit tests if necessary, in a separate PR.
@fizruk Thanks for the review! You've earned +49 points for this: +25 as a basis; +34 for the 340 hits-of-code that you reviewed; -10 for too few (3) comments. Your running balance is +189.
@Anatolay Thanks for your review! While we appreciate your effort, reviewing your own contribution isn't recommended. You've earned +5 points: +25 base, -40 for self-review, +20 minimum adjustment. Remember, external reviews often provide valuable insights. Your current balance is +23. Keep up the good work, and consider inviting others to review your future contributions!
@deemp Hey there! 👋 Great job on the review! You've snagged +42 points for this one: +25 for being an awesome reviewer, +6 for tackling those 340 hits-of-code (that's a lot!), and +11 for your 11 insightful comments. 💬 Your effort really shows, especially since you avoided the -10 point deduction for having less than 6 comments. Keep up the fantastic work! Your running balance is now +130. Remember, the more you contribute, the more you earn. Looking forward to your next review! 🚀
Closes #36.
This PR adds:
yegor.yaml
PR-Codex overview
This PR introduces a new
RuleTestOption
type, allowing for test-specific options in the EO Phi rules. It also modifies test cases to include these options for more flexibility.Detailed summary
RuleTestOption
type for test-specific optionsRuleTestOption
for more flexibility