objectionary / normalizer

Command Line Normalizer of 𝜑-calculus Expressions
https://www.objectionary.com/normalizer/
MIT License
7 stars 2 forks source link

Add `R_DOT_ρ` #468

Closed eyihluyc closed 1 month ago

eyihluyc commented 1 month ago

Addresses https://github.com/objectionary/normalizer/issues/448.

Also fixes the ρ and nested dispatches test.

This test is fixed in https://github.com/objectionary/normalizer/pull/449 but the results are different, likely because of the reductions in ρ.

This is a result here (1) and in #449 (2):

1. ⟦ x ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.ρ, ρ ↦ ⟦ a ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.ρ ⟧ ⟧ ⟧, λ ⤍ Package ⟧
2. ⟦ x ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.ρ, ρ ↦ ⟦ a ↦ ⟦ b ↦ ⟦ c ↦ ξ.ρ ⟧.c ⟧.b ⟧ ⟧, λ ⤍ Package ⟧

Turns out (2) can be reduced to (1)


PR-Codex overview

This PR updates dataization and rule definitions in the eo-phi-normalizer module. It modifies dataization output and adds a new rule for accessing ρ-binding.

Detailed summary

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

0crat commented 1 month ago

@fizruk Hey there! 👋 Great job on the review, you've snagged +5 points! Here's the breakdown: +25 for being the author, but we had to deduct 20 because there weren't any comments this time. Remember, more comments can boost your score – up to 20 points! Your current balance is sitting pretty at +280. Keep up the good work, and don't forget to leave some thoughtful comments next time to maximize your bonus! 💪

0crat commented 1 month ago

@eyihluyc Thank you for your contribution! Your effort is appreciated, but there's room for improvement. Here's the breakdown: +25 points as a base, -10 for no reviewer comments, and -10 for submitting only 19 hits-of-code (below the 20 minimum). This results in a total of +5 points. Remember, code reviews and meaningful contributions are crucial for our team's success. Keep working on improving both quantity and quality. Your current balance stands at +45. Looking forward to your next contribution!