search

objective-see / DNSMonitor

A DNS Monitor, leveraging Apple's NEDNSProxyProvider/Network Extension Framework
GNU General Public License v3.0
167 stars 20 forks source link

bug with tcp dns packet parse #2

Closed triste24 closed 1 year ago

triste24 commented 1 year ago

@objective-see test after commenting this line image length -= sizeof(uint16_t); seems to be unnecessary.data.length=29 andsizeof(uint16_t)=2,so the length of packet is 27,no need to minus 2 again. image image

objective-see commented 1 year ago

Good catch! Much appreciated 👍🏽