objectscript / LightPivotTable

Lightweight pivot table representation for MDX2JSON source for InterSystems Cache
MIT License
3 stars 4 forks source link

LPT calculates uses different formulas for row totals #4

Closed evshvarov closed 5 years ago

evshvarov commented 7 years ago

Fore revenue it sums the value, but for count it sums the amount of rows.

2017-02-12 11 24 56

Testcase: http://146.185.143.59/dsw/index.html#!/d/test/LPT4.dashboard#%2F%3Fns=SAMPLES

nikitaeverywhere commented 6 years ago

LPT implements COUNT aggregate as a count of non-empty rows displayed. Should this turn into SUM of values? If it is, how is it different from SUM aggregate?

evshvarov commented 5 years ago

For Total it should be always SUM

nikitaeverywhere commented 5 years ago

Done https://github.com/intersystems-ru/LightPivotTable/releases/tag/1.8.13 (I noticed that v1.8.13 was published in releases before while it should have been v1.8.12. So I've updated description and attached zip archive)

nikitaeverywhere commented 5 years ago

However, I don't like this fix: I think it will bubble up shortly somewhere.