search

oblac / jodd-util

Essential Java utilities.
https://util.jodd.org
BSD 2-Clause "Simplified" License
39 stars 9 forks source link

Improving JulianDateTime #13

Closed igr closed 1 year ago

igr commented 1 year ago

@cusher Let's work on the JulianDateTime here.

This is what has been done:

Discussion is here

The initial PR is #12

igr commented 1 year ago

Awesome @cusher , thank you!

codecov[bot] commented 1 year ago

Codecov Report

Base: 74.49% // Head: 74.65% // Increases project coverage by +0.15% :tada:

Coverage data is based on head (833d872) compared to base (7c40e6f). Patch coverage: 75.86% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #13 +/- ## ============================================ + Coverage 74.49% 74.65% +0.15% - Complexity 2914 2920 +6 ============================================ Files 128 128 Lines 9337 9327 -10 Branches 1947 1945 -2 ============================================ + Hits 6956 6963 +7 + Misses 1884 1867 -17 Partials 497 497 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `74.65% <75.86%> (+0.15%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/oblac/jodd-util/pull/13?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac) | Coverage Δ | | |---|---|---| | [src/main/java/jodd/time/TimeUtil.java](https://codecov.io/gh/oblac/jodd-util/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac#diff-c3JjL21haW4vamF2YS9qb2RkL3RpbWUvVGltZVV0aWwuamF2YQ==) | `45.45% <0.00%> (-4.55%)` | :arrow_down: | | [src/main/java/jodd/time/JulianDate.java](https://codecov.io/gh/oblac/jodd-util/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac#diff-c3JjL21haW4vamF2YS9qb2RkL3RpbWUvSnVsaWFuRGF0ZS5qYXZh) | `64.53% <81.48%> (+8.98%)` | :arrow_up: | | [src/main/java/jodd/introspector/Properties.java](https://codecov.io/gh/oblac/jodd-util/pull/13/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac#diff-c3JjL21haW4vamF2YS9qb2RkL2ludHJvc3BlY3Rvci9Qcm9wZXJ0aWVzLmphdmE=) | `91.76% <0.00%> (+1.17%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=oblac)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.