oblac / jodd

Jodd! Lightweight. Java. Zero dependencies. Use what you like.
https://jodd.org
BSD 2-Clause "Simplified" License
4.06k stars 723 forks source link

Fix LazyMap#values returning Suppliers #696

Closed slandelle closed 5 years ago

slandelle commented 5 years ago

Motivation:

LazyMap#values shoudn't return Suppliers but real values.

Modification:

Have LazyMap#values always build the actual Map instead of returning values that might be Suppliers (ObjectParsers).

Result:

LazyMap#values returns actual values

slandelle commented 5 years ago

Ping @igr

codecov[bot] commented 5 years ago

Codecov Report

Merging #696 into master will increase coverage by <.01%. The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #696      +/-   ##
============================================
+ Coverage     66.48%   66.49%   +<.01%     
- Complexity    11665    11666       +1     
============================================
  Files           891      891              
  Lines         45705    45701       -4     
  Branches       7398     7397       -1     
============================================
+ Hits          30389    30390       +1     
+ Misses        12902    12899       -3     
+ Partials       2414     2412       -2
Impacted Files Coverage Δ Complexity Δ
jodd-json/src/main/java/jodd/json/LazyMap.java 53.42% <100%> (+5.37%) 20 <3> (+1) :arrow_up:
...c/main/java/jodd/exception/UncheckedException.java 32.3% <0%> (-6.16%) 7% <0%> (-1%)
...ore/src/main/java/jodd/cache/AbstractCacheMap.java 83.95% <0%> (+3.7%) 26% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f4a1112...becdc47. Read the comment docs.

igr commented 5 years ago

Awesome, merging and releasing now!!!!

slandelle commented 5 years ago

Thanks a lot!