oblac / jodd

Jodd! Lightweight. Java. Zero dependencies. Use what you like.
https://jodd.org
BSD 2-Clause "Simplified" License
4.06k stars 723 forks source link

Fix closeFolderIfOpened #724

Closed jhult closed 5 years ago

jhult commented 5 years ago

Current behavior

An IllegalStateException will be thrown if the folder is not already open

New behavior?

Only attempt to close the folder if it is open

codecov[bot] commented 5 years ago

Codecov Report

Merging #724 into master will increase coverage by 0.01%. The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #724      +/-   ##
============================================
+ Coverage     64.75%   64.76%   +0.01%     
- Complexity    11391    11395       +4     
============================================
  Files           892      892              
  Lines         45779    45779              
  Branches       7395     7395              
============================================
+ Hits          29642    29648       +6     
+ Misses        13803    13799       -4     
+ Partials       2334     2332       -2
Impacted Files Coverage Δ Complexity Δ
...il/src/main/java/jodd/mail/ReceiveMailSession.java 0% <0%> (ø) 0 <0> (ø) :arrow_down:
...src/main/java/jodd/madvoc/MadvocServletFilter.java 80.64% <0%> (-9.68%) 7% <0%> (ø)
jodd-core/src/main/java/jodd/io/StreamGobbler.java 66.66% <0%> (+2.38%) 5% <0%> (+1%) :arrow_up:
...ore/src/main/java/jodd/cache/AbstractCacheMap.java 85.18% <0%> (+4.93%) 27% <0%> (+2%) :arrow_up:
...c/main/java/jodd/exception/UncheckedException.java 38.46% <0%> (+6.15%) 8% <0%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8fd9f64...782c489. Read the comment docs.

igr commented 5 years ago

Thank you!