search

oblador / react-native-animatable

Standard set of easy to use animations and declarative transitions for React Native
MIT License
9.82k stars 701 forks source link

componentWillReceiveProps to getDerivedStateFromProps #280

Closed wanderbon closed 3 years ago

IntelliJAbhishek commented 5 years ago

@wanderbon You can't use this inside static method.

wanderbon commented 5 years ago

@IntelliJAbhishek

Thanks, got rid of the getDerivedStateFromProps.

marlonjohnynion commented 5 years ago

Can't wait to get this merged.

jtibbertsma commented 5 years ago

So I tested it out, and this pull request breaks transitions. To make transitions work, the new styles have to be intercepted before the component rerenders in order to set up a smooth transition to the new styles. You can't just throw everything in componentDidUpdate and expect it to work. The solution will have to use some combination of getDerivedStateFromProps and componentDidUpdate.

I'll give it a shot, though. I'm sick of the constant warnings in my app

oblador commented 5 years ago

@jtibbertsma Help would be greatly appreciated, thx :-)

AfrazHussain commented 4 years ago

Hey, does anyone have any information on when this PR will be merged? If no one has worked on the requested changes, I can give it a shot ASAP.

P.S. If anyone is looking to disable YellowBox warnings just for the time being they can use YellowBox.ignoreWarnings([]).

fri0z commented 4 years ago

Who knows when PR will accept ?

wilforlan commented 4 years ago

@oblador @oliverdolgener please guys, what is stoping this PR?

oblador commented 4 years ago

I will look more into this one later, but for now you can use 1.3.3 to remove the warning.

jtibbertsma commented 4 years ago

@wilforlan This pull request breaks features of this library

esdotzed commented 4 years ago

any updates on this?

oblador commented 3 years ago

Closing this PR, warning is gone for now and it breaks functionality.