Add style prop to create cards/containers

oblador / react-native-collapsible

Animated collapsible component for React Native, good for accordions, toggles etc

MIT License

2.46k stars 452 forks source link

Closed M-Jas closed 6 years ago

M-Jas commented 6 years ago

Gives users the ability to add styling to the entire accordion container. We needed to create cards for each header item in the accordion that were seamlessly connected to header. Please see the image below.

Your PR process requests that we push to the next branch, but I only see master.

simulator screen shot - iphone x - 2018-10-03 at 10 07 25

iRoachie commented 6 years ago

Man that is a beautiful app 💯, seems like a duplicate of #246 . However if you can finish the changes before, then i'll merge yours.

Still need to add typescript definitions and fix the ci

M-Jas commented 6 years ago

@iRoachie Sorry I added the wrong picture, but the new one is up with the Accordion in full force. I'll take a look into #246 and Mr. Travis.

M-Jas commented 6 years ago

@iRoachie how do you run the ci locally? I don't have this '.' it speaks of.

iRoachie commented 6 years ago

You can run npm run test --fix and see if that works

M-Jas commented 6 years ago

@iRoachie helps if you npm i 😞. I think this last push should do the trick.

iRoachie commented 6 years ago

iRoachie commented 6 years ago

Oops forgot the docs! Add it to the readme

M-Jas commented 6 years ago

Ok this time for real! Sorry for the back and forth.

iRoachie commented 6 years ago

Thanks mate! Release will be out soon