oblador / react-native-collapsible

Animated collapsible component for React Native, good for accordions, toggles etc
MIT License
2.47k stars 452 forks source link

Calling `getNode()` on the ref of an Animated component is no longer necessary #347

Open Ho3ein-Boka opened 4 years ago

Ho3ein-Boka commented 4 years ago

Calling getNode() on the ref of an Animated component is no longer necessary. You can now directly use the ref instead. This method will be removed in a future release.

pistou commented 4 years ago

This should be corrected by #346 .. Any ETA?

marcoaras commented 4 years ago

ReactNativeFiberHostComponent: Calling getNode() on the ref of an Animated component is no longer necessary. You can now directly use the ref instead. This method will be removed in a future release.

Still continue in last version.

JeanRoldanDev commented 4 years ago

Solucion 25a7ad2

image

OsamaMukhtar commented 4 years ago

Solucion 25a7ad2

image

When will this merged please.

nashford77 commented 4 years ago

+1 this really needs to be merged and corrected.

renishg commented 4 years ago

+1 Waiting for PR to be merged

awkpagong commented 4 years ago

+1 did the maintainer die of corona virus or something?

leurs247 commented 4 years ago

Did someone find a solution for this?

Edit:

In file https://github.com/oblador/react-native-collapsible/blob/master/Collapsible.js on line 88: removing the getNode() function from the chain fixes the issue.

willcaul commented 4 years ago

@yesterday24 I used patch-package to apply @marcorm's fix #346 to my project while we wait for the fix to be merged into the react-native-collapsible repo

Edit:

@yesterday24 for your use case, if you are locked into RN 0.62 or higher, you could create a patch that does what you mentioned in your comment and ignore the backwards compatibility part of marcorm's fix if you don't need backwards compatibility

Edit 2:

This issue is fixed now in version 1.5.3, so the patch workaround is no longer necessary once you upgrade: https://github.com/oblador/react-native-collapsible/pull/349

elpolyglotino commented 4 years ago

same problem here

liran commented 4 years ago

Why can't I install version 1.5.3? image image