Replaced with prop-types and RN upgrade

oblador / react-native-collapsible

Animated collapsible component for React Native, good for accordions, toggles etc

MIT License

2.43k stars 453 forks source link

Closed JijoBose closed 3 years ago

JijoBose commented 4 years ago

React Native version upgrade to 0.63.2
Replaced ViewProptypes with prop-types - Fixes #355 Since ViewPropTypes now is deprecated on the latest version of react-native-web

Silventino commented 3 years ago

up!

soroushm commented 3 years ago

@oblador can you take care of it?

ianmartorell commented 3 years ago

This is needed for the package to work with React Native Web!

ianmartorell commented 3 years ago

I'm using this branch now with RNW and it works great. Hoping it gets merged.

JijoBose commented 3 years ago

@ianmartorell Thank you so much for the review 😄

JijoBose commented 3 years ago

@oblador Is this good to go ?

samtsai commented 3 years ago

@oblador Bump to see if we can get this merged and released 😄

kgrech commented 3 years ago

@oblador Can we please get this merged and released :)

JijoBose commented 3 years ago

@oblador Can we get this PR merged?

soroushm commented 3 years ago

I personally after install the npm package should manually change this line to resolve the error on the web app @oblador please merge it 🥇

Silventino commented 3 years ago

If you are tired of waiting and having to fix this manually, you can install from JijoBose fork as a workaround:

yarn add https://github.com/JijoBose/react-native-collapsible.git#bug/proptype

JackKenney commented 3 years ago

@Silventino thanks! 🙏🏼 Hoping to see this to get merged soon. Using your version in the meantime 💯

oblador commented 3 years ago

Superseded by #399