search

oblador / react-native-collapsible

Animated collapsible component for React Native, good for accordions, toggles etc
MIT License
2.43k stars 455 forks source link

Migrate to use reanimated #401

Closed oblador closed 2 years ago

oblador commented 3 years ago

Pro: Allows us to use native driver for smoother animations. Con: Breaking change that adds a new dependency, however the majority of RN installations already have it.

HashibulAmin commented 3 years ago

+1

oblador commented 3 years ago

@HashibulAmin & @akinncar Have you tried this PR out? Would love to get some feedback from real world use cases.

akinncar commented 3 years ago

I just tried this feature with the Example app, and create a repo to test it https://github.com/akinncar/expo-collapsible-example

"react-native-collapsible": "git://github.com/oblador/react-native-collapsible.git#reanimated" on package.json

iOS Device

Android Emulator

Let me know if I can help with anything more, I don't have other examples yet.

oblador commented 3 years ago

@akinncar Thanks! I've tried those as well, would be great to have some real world tryouts too 👍

ibealec commented 2 years ago

Nice improvement! I tried this in my project and the animation is noticeably smoother. Not sure how others would feel about the "Pure JavaScript" part going away, but as someone who just needs this on mobile and already has reanimated installed, it was a welcome change.

mwegener-com commented 2 years ago

Working fine in my project. Bug with nested collapsibles still exists.

fobos531 commented 2 years ago

Hey @oblador, is a new version which includes this change going to be published to NPM?

avr6ude commented 1 year ago

Why reanimated was removed? I can't quite find the reason.

wmonecke commented 10 months ago

@oblador Could you help me understand why this PR was reverted? I really enjoy using this package but with 120Hz displays the current JS implementation has started to fall behind my other Reanimated components.

Would you be willing to merge a PR with the reanimated v2 API? I would gladly submit one.