Typescript CollapsibleProps doesn't contain childre

oblador / react-native-collapsible

Animated collapsible component for React Native, good for accordions, toggles etc

MIT License

2.47k stars 452 forks source link

Typescript CollapsibleProps doesn't contain childre #436

Open teyalite opened 2 years ago

teyalite commented 2 years ago

There is no property children?: React.ReactNode; in CollapsibleProps.

mohandarsi commented 2 years ago

MikeyAlmighty commented 2 years ago

Hi @teyalite Did you find a potential workaround for this?

teyalite commented 2 years ago

@MikeyAlmighty yes, i added the child prop to it in the source file in node_modules

kaolin commented 2 years ago

FWIW ~

diff --git a/node_modules/react-native-collapsible/index.d.ts b/node_modules/react-native-collapsible/index.d.ts
index 26f8d56..7acf736 100644
--- a/node_modules/react-native-collapsible/index.d.ts
+++ b/node_modules/react-native-collapsible/index.d.ts
@@ -93,6 +93,12 @@ export interface CollapsibleProps {
    * Function called when the animation finished
    */
   onAnimationEnd?: () => void;
+
+  /**
+   * Children! https://github.com/oblador/react-native-collapsible/issues/436
+   */
+  children?: React.ReactNode;
+
 }

 export default class Collapsible extends React.Component<CollapsibleProps> {}

kubik369 commented 2 years ago

This is due to the update to React 18, where children props need to be stated in the type explicitly.

@oblador Would you accept a PR with this single change? AFAIK it does not affect older versions. Thanks for the reply :)

Andreas-Sujono commented 2 years ago

@oblador still get this issue

marioacero commented 2 years ago

@oblador could you add that fix?

makarewicz77 commented 2 years ago

I'm also facing the issue and would appreciate a fix for this one. I'm not considering changing the index.d.ts from node_modules as a proper solution.