search

oblador / react-native-keychain

:key: Keychain Access for React Native
MIT License
3.12k stars 515 forks source link

Disable Android Jetifier #580

Closed androideveloper closed 11 months ago

androideveloper commented 1 year ago

Overview

As the project is migrated to AndroidX and robolectric is updated to 4.7.3 (which include one more migration to androidx), we should be safe by disabling jetifier on Android, which removes additional build steps and potentially saves build time.

The flag is false by default if it is not specified.

androideveloper commented 1 year ago

@oblador builds are green 😊

diegodorado commented 1 year ago

Why isn't this merged? Is jetifier a requirement?

Edit: I see, @androideveloper, your PR does not update roboelectric version

androideveloper commented 1 year ago

As I wrote in the PR description:

As the project is migrated to AndroidX and robolectric is updated to 4.7.3 (which include one more https://github.com/robolectric/robolectric/pull/5525 to androidx), we should be safe by disabling jetifier on Android, which removes additional build steps and potentially saves build time.