oblador / react-native-keychain

:key: Keychain Access for React Native

MIT License

3.18k stars 519 forks source link

[Fix][Android] Bugfix for lambda functions not workin in older projects. #585

Closed sohail-shrestha closed 7 months ago

sohail-shrestha commented 1 year ago

Issue #571

The following lines of code were added to android's build.gradle.

  compileOptions {
    sourceCompatibility JavaVersion.VERSION_1_8
    targetCompatibility JavaVersion.VERSION_1_8
  }

What this fixes:

Older react native projects not handling lambda functions.

Error Message:

 error: method references are not supported in -source 7
    final Thread warmingUp = new Thread(instance::internalWarmingBestCipher, "keychain-warming-up");
                                                  ^
  (use -source 8 or higher to enable method references)

varunkukade commented 1 year ago

@oblador Can you please merge this PR. Or else could you please suggest me what changes are not as per expectation. I will try to do those and create new PR. Thanks.