search

oblador / react-native-lightbox

Images etc in Full Screen Lightbox Popovers for React Native
MIT License
2.82k stars 502 forks source link

This should be `this.props.onClose()` #114

Closed ly9310 closed 5 years ago

ly9310 commented 5 years ago

https://github.com/oblador/react-native-lightbox/blob/4448979323623a56c62b5f8be1032322485cbd31/Lightbox.js#L112

mccabemj commented 5 years ago

@ly9310 no it shouldn't. The second parameter to setState() is an optional callback function. It's just referencing the function that setState will call. Its not meant to initiate the onClose function

ly9310 commented 5 years ago

Emmmmm,I understand, Thanks for your reply.