search

oblador / react-native-lightbox

Images etc in Full Screen Lightbox Popovers for React Native
MIT License
2.82k stars 502 forks source link

move to https://github.com/react-native-community? #129

Open sibelius opened 4 years ago

sibelius commented 4 years ago

are you willing to move to https://github.com/react-native-community?

Lightbox is great, but it is generating a bunch of warning in newer version of react-native

backend.js:32 Animated: `useNativeDriver` was not specified. This is a required option and must be explicitly set to `true` or `false` 
backend.js:32 Warning: componentWillMount has been renamed

moving there we can add more maintainers and fix all of this issues

rarenatoe commented 4 years ago

Shameless bump.

Does anyone know any alternatives to this clearly abandoned repository?

Razorholt commented 4 years ago

@renato-bvdash: No but if you do, please share :)

cromatikap commented 4 years ago

Hi, I made a quick patch to remove the warnings:

diff --git a/node_modules/react-native-lightbox/LightboxOverlay.js b/node_modules/react-native-lightbox/LightboxOverlay.js
index 9e01f9a..bf11c7e 100644
--- a/node_modules/react-native-lightbox/LightboxOverlay.js
+++ b/node_modules/react-native-lightbox/LightboxOverlay.js
@@ -99,7 +99,7 @@ export default class LightboxOverlay extends Component {
       onPanResponderMove: Animated.event([
         null,
         { dy: this.state.pan }
-      ]),
+      ], { useNativeDriver: false }),
       onPanResponderTerminationRequest: (evt, gestureState) => true,
       onPanResponderRelease: (evt, gestureState) => {
         if(Math.abs(gestureState.dy) > DRAG_DISMISS_THRESHOLD) {

I used patch-package.

If you want to patch it by hand, just open /node_modules/react-native-lightbox/LightboxOverlay.js and modify the line 102 to add { useNativeDriver: false } as a secondary option of Animated.event()

azhararmar commented 4 years ago

Sadly, there are no other library good as this. How I wish this is moved to react-native-community and maintained.

jdegger commented 4 years ago

Honest question: since this is licensed as MIT, is it acceptable/respected of somebody else took the code and published it to the community?

jacquesdev commented 4 years ago

Probably, but it would be more useful if @oblador agreed with this :) Does anyone know the process for this, ie to move it to community?

cromatikap commented 4 years ago

@jacquesdev https://github.com/react-native-community/discussions-and-proposals might be a good start to find out :)

karimcambridge commented 4 years ago

Please!!!

andrescuco commented 3 years ago

Bump. Also, if anyone knows of any up to date alternative it would be great.

rarenatoe commented 3 years ago

I ended up using react-native-image-viewing for my own very particular needs. It works very well for react native.