search

oblador / react-native-lightbox

Images etc in Full Screen Lightbox Popovers for React Native
MIT License
2.82k stars 502 forks source link

Rewrote to es6 classes. Added prop-types for rn >= 0.44. #78

Closed bintoll closed 7 years ago

bintoll commented 7 years ago

Added prop-types dependency and fix this in code. Rewrote two component s in es6 classes.

justim commented 7 years ago

Your package.json has a syntax error, can you please fix this?

bintoll commented 7 years ago

Yes, done.

justim commented 7 years ago

Thanks! Lightbox is now at least usable again with your PR 👍

For anyone else wanting to use this PR:

{
  // ...
  "dependencies": {
    // ...
    "react-native-lightbox": "github:oblador/react-native-lightbox#ade502ae2d25ff0031e0d8dce703606ce280f822",
  }
}
oblador commented 7 years ago

This is great, thanks! I'll review and test as soon as i get the chance. Would you care helping me maintain the lib?

bintoll commented 7 years ago

If you need a help - i can, of course.

bintoll commented 7 years ago

Okay, i'll rewrite it tomorrow, it's not a problem. First time the main propose was just to move to es6 classes and not to beautify code) But okay, i also prefer good looking code)

oblador commented 7 years ago

OK, merging this and fixing the syntax separately instead.

oblador commented 7 years ago

Released in 0.7.0