search

oblador / react-native-progress

Progress indicators and spinners for React Native
MIT License
3.63k stars 516 forks source link

Migrate usages of @react-native-community/art to react-native-svg #229

Closed frw closed 3 years ago

frw commented 3 years ago

@react-native-community/art could be deprecated soon: react-native-art/art#75 This pull requests replaces usages of @react-native-community/art with the well-supported react-native-svg library.

This should also resolve #183

frw commented 3 years ago

Tested with Example app:

https://user-images.githubusercontent.com/1888212/123537932-4f294580-d75c-11eb-8607-b3775f99943f.mp4

frw commented 3 years ago

@oblador Found the issue. It seems that passing in a rotation transform to the Svg component in Circle.js when it's no longer rotating causes it to be flipped. I'm not exactly sure why this is the case, but found a workaround to pass in an undefined style when there is no rotation and this seems to have fixed it.

https://user-images.githubusercontent.com/1888212/124013047-07304a00-da0c-11eb-9b95-169689502095.mp4

asklar commented 3 years ago

CC @marlenecota - any concerns about functionality in svg that this PR depends on, re: the Windows support you're adding, or should we be good?

frw commented 3 years ago

@oblador Could you take a quick look at this?

oblador commented 3 years ago

Released in 5.0.0

mikehardy commented 3 years ago

Likewise @oblador thanks for your work here and on react-native-vector-icons, I use both in my projects to great effect, I really appreciate it. Cheres