Plans to integrate Font Awesome Duotone

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.

https://oblador.github.io/react-native-vector-icons/

MIT License

17.44k stars 2.12k forks source link

Plans to integrate Font Awesome Duotone #1053

Open jwaldrip opened 5 years ago

jwaldrip commented 5 years ago

Font awesome just released duotone icons today. Are there plans to integrate it on React-Native-Vector icons.

hampustagerud commented 5 years ago

I've seen them, they look really nice and I would love to have them integrated! I havn't looked into it but might get to it in the coming days 🙂

Manouli commented 5 years ago

@hampustagerud Any update on this? I could really use this right now. 😅

BasBuur commented 5 years ago

Yep, duotone support would be a-mazing!

Taaqif commented 5 years ago

There is a challenge with this as the duotone icons are essentially 2 separate glyphs stacked on top of each other.

Edit: Further to this, the glyphs themselves are separated in the font file and stacked on top of each other using CSS styling. The duotone effect is actually just one glyph with a different opacity than the other.

Creating this effect should theoretically be possible but after some investigation it appears that supporting this would put more focus on the FontAwesome aspect potentially making the module less generic. Would still love to see the effect and happy to help develop it

FRizzonelli commented 4 years ago

Any update on this? It would be awesome to use duotone :)

FRizzonelli commented 4 years ago

@oblador Is there anything we can do? I saw PR #1084 from @Taaqif and it seems its almost working!

hampustagerud commented 4 years ago

Hey, sorry for going a-wall on this. Life got in the way and I had to prioritize 🙂 I hacked together a POC for Duotone last night, the PR referenced above does not take into account the different internal workings on Duotone vs normal icons so it requires a bit more work than just including the icons the normal way! I have to do some changes to the core itself so I will have to have some discussions with @oblador before I make a PR.

Please note that I need a bit more time with this but here is a sneak peek:

patrickreiner commented 4 years ago

Definitely +1 on this feature, would love duotone icons

envisean commented 4 years ago

Hey guys, just checking in here, but any updates on this?

FRizzonelli commented 4 years ago

@hampustagerud Can you open the PR? Maybe someone else can help you out to complete the missing parts <3

patrickreiner commented 4 years ago

Just wanted to let everyone know that Font Awesome rolled out their own implementation, with support for duotone and everything. See https://github.com/FortAwesome/react-native-fontawesome

hampustagerud commented 4 years ago

@FRizzonelli I have created a PR now, it is probably not entirely ready but if you and others (@Manouli @Moosieboy) could help try it out that would be awesome 👍 Again, sorry for the delay but during these strange times I have to (more than ever) prioritise what pays the bills first and unfortunately that is no longer so much RN 🙂 I appreciate the patience and hope not too many bugs are found 😉 The fork is in-sync with master so trying out the fork should not loose any functionality!

FRizzonelli commented 4 years ago

@FRizzonelli I have created a PR now, it is probably not entirely ready but if you and others (@Manouli @Moosieboy) could help try it out that would be awesome 👍 Again, sorry for the delay but during these strange times I have to (more than ever) prioritise what pays the bills first and unfortunately that is no longer so much RN 🙂 I appreciate the patience and hope not too many bugs are found 😉 The fork is in-sync with master so trying out the fork should not loose any functionality!

Gonna try it in few days! Thank you so much!