fontweight is always normal - Githubissues

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.

https://oblador.github.io/react-native-vector-icons/

MIT License

17.45k stars 2.12k forks source link

fontweight is always normal #1285

Open sirpy opened 3 years ago

sirpy commented 3 years ago

[x] Review the documentation: https://github.com/oblador/react-native-vector-icons
[x] Search for existing issues (including closed issues): https://github.com/oblador/react-native-vector-icons/issues

Environment

react-native-web

Description

the create-icon-set.js contains code that always override some font styles https://github.com/oblador/react-native-vector-icons/issues/1188#issuecomment-737722786 so fontWeight and fontStyle are always normal and not possible to modify by passing style to component is this intentional? maybe add comment in code if so

const styleOverrides = {
        fontFamily: fontReference,
        fontWeight: 'normal',
        fontStyle: 'normal',
      };

      props.style = [styleDefaults, style, styleOverrides, fontStyle || {}];

sirpy commented 1 year ago

bump