oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.4k stars 2.12k forks source link

Update to latest Material Icons by Google and add outlined Material Icons #1372

Closed jsproede closed 11 months ago

jsproede commented 3 years ago

Hi,

it looks like that the referenced Material Icons commit hash was not the latest hash of the v4.0.0 Material Icons. We've updated the commit hash reference to the newest hash.

Additionally we needed the outlined Material Icons and added them to this repository. For the outlined Material Icons we needed to install FontForge (brew install fontforge) which converts the .otf file to a .ttf file, because Google provides the outlined Material Icons only as .otf file. We've added this dependency to the CONTRIBUTING.md file because it is required to update the outlined Material Icons.

In conclusion:

Unfortunately the script npm run build does not work:

Archive:  /var/folders/.../entypo.zip
  End-of-central-directory signature not found.  Either this file is not
  a zipfile, or it constitutes one disk of a multi-part archive.  In the
  latter case the central directory and zipfile comment will be found on
  the last disk(s) of this archive.

This is the last step to fulfill all steps of your contribution guidelines.

If there is anything missing, feel free to let us know and we'll update this pull request ๐Ÿ™‚

vitogoh commented 3 years ago

i hope the outlined version of this icon is going to be part of the udpate. ๐Ÿคž ๐Ÿ™ https://fonts.google.com/icons?selected=Material+Icons&icon.query=no+photo

jsproede commented 3 years ago

Hi @vitogoh. Yes, the outlined no-photography icon is included in this PR :) As we needed some of the new and outlined icons in one of our projects, we've installed our fork directly in our projects package.json:

"react-native-vector-icons": "nanogiants/react-native-vector-icons#feature/materialicons"
vitogoh commented 3 years ago

Hi @vitogoh. Yes, the outlined no-photography icon is included in this PR :) As we needed some of the new and outlined icons in one of our projects, we've installed our fork directly in our projects package.json:

"react-native-vector-icons": "nanogiants/react-native-vector-icons#feature/materialicons"

๐Ÿ‘

svbutko commented 3 years ago

@oblador sorry for mentioning but is there anyway to merge this PR, since it brings lots of improvements and it has been some time since the author created this PR

CyxouD commented 2 years ago

This PR includes the icons which I really need: "password" and "tips and updates"

CyxouD commented 2 years ago

I got Unrecognized font family 'Material Icons Outlined error on iOS (iPhone 11 simulator, iOS 15.0, react-native 0.63.4). To fix it I also had to add UIAppFonts in Info.plist (as described in manual setup for iOS). In my case it is

    <key>UIAppFonts</key>
    <array>
    <string>MaterialIconsOutlined.ttf</string>
    <string>MaterialCommunityIcons.ttf</string>
    </array>

@jsproede could it be the issue with the PR?

image

jsproede commented 2 years ago

Hi @CyxouD,

it looks like that the Material Icons Outlined font could not be loaded. Did you add the MaterialIconsOutlined.ttf to your Fonts folder in Xcode as described in the documentation you've linked in your last comment? :)

Fonts

CyxouD commented 2 years ago

Hi @jsproede!

Actually, it was enough for me just to change Info.plist without copying Fonts folder. I've added project with Cocoapods option and just found out that it was required to Edit Info.plist as described above.. I don't know how it used to work before (without the change to Info.plist), but now we know that is my mistake to not edit Info.plist. I'm sorry to trouble you!

Thank you for your PR, it really helps!

mattahorton commented 2 years ago

Any activity on this?

sutefan1 commented 2 years ago

@jsproede @oblador Seems like a busy guy, but he mentioned in his readme to reach out to him over Twitter (https://twitter.com/trastknast). Maybe you could take some maintenance work from him if you got the time.

Even just bumping the icon version on a regular basis would help out a lot for many people.

ser-emejia commented 2 years ago

Any update on this?

krambout-seche commented 2 years ago

Any news about this merge ?

jsproede commented 2 years ago

Unfortunately, I never got a response from @oblador. We also tried to reach him via Twitter.

tux2nicolae commented 2 years ago

Bumping this up, I'm also interested in this PR

yo9e5h commented 1 year ago

Any plans to merge this PR?

Max-DVS commented 1 year ago

It would be lovely if this PR is approved :)

hyetigran commented 1 year ago

Bumping this up, would be nice to update the MaterialIcons lib

wanschi commented 1 year ago

Bump

smisaacs commented 1 year ago

+1 Bump

alex-lanclos commented 1 year ago

+1 bump, having to patch this package locally with these changes

alex-lanclos commented 1 year ago

react-native-vector-icons+9.2.0.patch

You can have this running on your projects without having to fork if you use the above patch and use

"copyFiles": [
    {
      "from": "<Point to font>/MaterialIcons.ttf",
      "to": "node_modules/react-native-vector-icons/Fonts/MaterialIcons.ttf"
    },
    {
      "from": "<Point to font>/MaterialIconsOutlined.ttf",
      "to": "node_modules/react-native-vector-icons/Fonts/MaterialIconsOutlined.ttf"
    }
  ]

and have

npx copy-files-from-to --when-file-exists overwrite

run as part of your postinstall

topzdev commented 1 year ago

The material icons of this library are outdated, can the author of this repo merge this commit?

johnf commented 11 months ago

Material Icons has been updated since this PR was created. If someone is willing to create a PR for Outline support I'll be happy to review and merge. I suggest doing this in a similar way to FontAwesome where it uses the existing Element but we add a variant/style field to pick outline, sharp etc