oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.

https://oblador.github.io/react-native-vector-icons/

MIT License

17.31k stars 2.12k forks source link

Add support for FontAwesome 6 #1449

Closed basbase closed 11 months ago

basbase commented 1 year ago

1408

cdownard commented 1 year ago

:+1: Let's goooooo :D

rvasseur31 commented 1 year ago

I wrote some comments, but they are only recommendations LGTM 👀❤️

In this case, it should also be changed there: https://github.com/oblador/react-native-vector-icons/blob/master/FONTAWESOME5.md#usage

a-tokyo commented 1 year ago

Neat! Thanks for this!

mgruntowski commented 1 year ago

Hey guys, any update here? 👀

a-tokyo commented 1 year ago

@johnf Can you please review this again so we can merge? ✨

johnf commented 1 year ago

@johnf Can you please review this again so we can merge? sparkles

Not sure if my review will matter, I'm not a maintainer? If @basbase isn't around to make more changes, I'm happy to take this on and get it into a mergable state though. I would probably

Add support for the other icon types
Look at merging the scripts into a single script that asks which fontawesome you want

basbase commented 1 year ago

I don't have time to make changes to this any more. It's working for me and the requested changes could be done later.

a-tokyo commented 1 year ago

Can we merge this?

a-tokyo commented 1 year ago

Alternative: Official FontAwesome library for React Native

TheDistanceHQ commented 1 year ago

How did you generate the glyphmaps? I see FA6 now has some new styles and would be happy to contribute to this PR to bring it up to date as its holding back creativity!

naleon commented 1 year ago

When this is gonna be merged?

oblador commented 11 months ago

Superseded by #1483