search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.31k stars 2.12k forks source link

Upgrade Ionicons to 5.5.2 #1457

Closed skb1129 closed 11 months ago

skb1129 commented 1 year ago

5.5.2 is the current version available on Ionicons website

I downloaded the SVGs, replaced stroke with fill using oslllo-svg-fixer then generated the TTF & Glyphmap using this script: https://gist.github.com/romanlv/0b5b1d5d942b01da9e7bd46f07d42584

@oblador can you please review and merge this PR on priority, let me know if there are any changes required PS: I have already tested all these icons on both Android and iOS devices

skb1129 commented 1 year ago

@oblador please review this PR

oblador commented 1 year ago

Thank you for your PR! I would strongly prefer that you updated the script used to generate this instead of relying on manual work. Could you have a look at scripts/ionicons.sh? Thanks!

skb1129 commented 1 year ago

@oblador I did look at the script but I do not think the script is going to work anymore as it expects the icons to be available in TTF format but the Ionicons library does not provide TTF anymore, it only provides the icons as SVG files so do have to rely on manual work until a better solution is found.

skb1129 commented 1 year ago

@oblador could you please merge this, it'll really be very helpful if you do.

mrkpatchaa commented 1 year ago

@skb1129 I used your technique to automate script generation in this pull request. #1484 @vitorGPorto @oblador Can you please take a look? Thanks.

oblador commented 11 months ago

Superseded by https://github.com/oblador/react-native-vector-icons/pull/1484