search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.31k stars 2.12k forks source link

fix: font weight being overriden for variable fonts #1489

Open matinzd opened 1 year ago

matinzd commented 1 year ago

Font weights are being overridden when it's being passed from the component style properties. I don't know if that's gonna break the current implementation of other font icons, but as far as I tested react native automatically applies normal fontWeight to the text if you don't pass it.

You can check font weights here with material symbols: https://fonts.google.com/icons

Android: WIP

matinzd commented 1 year ago

I delved further into the issue and discovered prior open issues indicating inadequate support for it on Android. As a result, let's hold off on implementing it until I can attempt to address the problem on Android and evaluate its feasibility. I'm confident that you, @oblador, have already considered this, but please let me know if you have any suggestions or why it wasn't resolved on the Android side. As far as I'm aware, we may need to choose a separate file for each font weight on Android, but variable fonts should function properly without any workarounds.