oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.31k stars 2.12k forks source link

package="com.oblador.vectoricons" found in source AndroidManifest.xml #1503

Closed Angelk90 closed 11 months ago

Angelk90 commented 1 year ago

Environment

OS: Mac OS 13.2.1 target platform: Android react-native: 0.71.8 react-native-vector-icons: ^9.2.0

Description

@oblador : I am getting the following warning, how do I remove it?

I created a project with the latest version of react native and simply installed the library.

package="com.oblador.vectoricons" found in source AndroidManifest.xml: 
/Users/nameUser/Desktop/project/node_modules/react-native-vector-icons/android/src/main/AndroidManifest.xml.
Setting the namespace via a source AndroidManifest.xml's package attribute is deprecated.
Please instead set the namespace (or testNamespace) in the module's build.gradle file, as described here: 
https://developer.android.com/studio/build/configure-app-module#set-namespace
This migration can be done automatically using the AGP Upgrade Assistant, please refer to 
https://developer.android.com/studio/build/agp-upgrade-assistant for more information.
saltire commented 11 months ago

I've gotten errors trying to build with Gradle v8:

Namespace not specified. Please specify a namespace in the module's build.gradle file like so:

android {
    namespace 'com.example.namespace'
}

Manually adding this to the build.gradle in my node_modules folder fixes the issue temporarily, and looks like there's already a PR to fix it properly: https://github.com/oblador/react-native-vector-icons/pull/1507

oblador commented 11 months ago

Fixed in 10.0.0