search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.31k stars 2.12k forks source link

fix(fonts.gradle): fix react native 0.73 build errors #1585

Closed alokparikh16 closed 2 months ago

alokparikh16 commented 5 months ago

Fix build errors on react native 0.73.x version.

This is similar to a previous fix done for 0.72 https://github.com/oblador/react-native-vector-icons/issues/1508#issuecomment-1606108215

Commit details: https://github.com/oblador/react-native-vector-icons/commit/e9cc5898a4331f5f9b9e03e3f5345c5cda3ebf61

elgreg commented 2 months ago

Would be great to see this merged! Manually editing files in node_modules is not the way. :(

sizuf commented 2 months ago

One more vote for merging!

elgreg commented 2 months ago

One more vote for merging!

@sizuf I ended up using patch-package in the meantime. 😬

BishoSBA commented 2 months ago

+1 to merge it 👀

johnf commented 2 months ago

@oblador I can't replicate this problem myself, but this seems to fix a problem for lots of folks, and I can't see it doing any harm. Can you merge?

VetSoftKeith commented 2 months ago

This is also affecting me from releasing with the update to RN 0.74. A merge would be really handy as I don't like using patches in production if I can avoid it. The changes in this PR 100% fix the issue.