Open michelcrypt4d4mus opened 5 months ago
@michelcrypt4d4mus We haven't tested on react-native-macos
yet.
I wanted to check first, did you rebuild the app? The error message seems to indicate that the common module isn't linked.
yes. as i said:
_Followed the install instructions, including a full re-install and rebuild of all node_modules and pod install from scratch, launched with a single page (see below), got this error:_
just to double check i did a full rebuild again including making sure i did a total purge of xcode's build files and got the same result.
The error message seems to indicate that the common module isn't linked.
yes i noticed this and assume it is some issue with the pod configuration i didn't delve too far into it because i'm not super knowledgeable about cocoapods but i was considering going in there and manually editing some of the pod related files to try to work around this.
i checked in my macos/Podfile.lock
file and there's no reference to VectorIcons
so it seems for some reason cd macos && pod install
isn't picking up this package.
i added this line to my Podfile
:
pod 'react-native-vector-icons', :path => '../node_modules/@react-native-vector-icons/common'
and then got a new error trying to run pod install
:
[!] The platform of the target `CanaryCastle-macOS` (macOS 10.15) is not compatible with
`react-native-vector-icons (0.0.1-alpha.6)`, which does not support `macOS`.
i was able to get a bit further by editing the podspec file to replace the line
s.platforms = { :ios => "12.0", :tvos => "9.0" }
with
s.platforms = { :ios => "12.0", :tvos => "9.0", :osx => "10.15" }
That at least got pod install
to complete successfully but then Xcode failed to build, presumably because of the use of UIColor
instead of NSColor
. Here's the Xcode alerts on VectorIcons.h
:
Changing the types from UIColor
to NSColor
got past that error but then it failed on running the Copy Fonts
script:
Having the same error on OSX 14.5:(
OK it looks like a bit more work to get Mac OS support then simply adding the platform.
It looks like someone had a go at this a very long time ago in https://github.com/oblador/react-native-vector-icons/pull/173
This is a bit past my expertise and I don't have access to a Mac for the next 5 weeks.
Happy to accept a PR if someone can get this all working. I'll update the README to point at this issue.
"@react-native-vector-icons/common": "^0.0.1-alpha.6"
(Usingmonorepo
branch)"@react-native-vector-icons/fontawesome": "^4.7.0-alpha.9",
npm --version
:10.5.0
node --version
:v21.7.2
package.json
:Description
Followed the install instructions, including a full re-install and rebuild of all
node_modules
andpod install
from scratch, launched with a single page (see below), got this error:Reproducible Demo
App.js
:src/app/components/app_config_panel.js
: