search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.31k stars 2.12k forks source link

Glyphmaps path issue #1628

Closed joemewes closed 2 weeks ago

joemewes commented 2 weeks ago

NB: Sorry if this is the wrong repo for the individual library issues.

Environment

Description

It looks like the lib compiled paths include a relative path for the glyph maps as follows:

import glyphMap from '../glyphmaps/MaterialDesignIcons.json'

This results in the following error:

ERROR in ./node_modules/@react-native-vector-icons/material-design-icons/lib/module/index.js 1:268-316
Module not found: Error: Can't resolve '../glyphmaps/MaterialDesignIcons.json'

I may have something wrong in my setup, but it looks like the compiled lib paths in the released lib wont match that of the src... also in the lib.

Screenshot 2024-06-12 at 16 29 08

Reproducible Demo

Just install "@react-native-vector-icons/material-design-icons": "^7.4.47-alpha.14", and try to build app/project.

johnf commented 2 weeks ago

This should be fixed in the latest release. Thanks for testing in RNW. Let me know if you notice any other issues or the install instructions could be improved

johnf commented 2 weeks ago

I just realised I haven't updated the install instructions for the new libraries yet, that section needs a complete overhaul