search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.46k stars 2.13k forks source link

docs: remove unnecessary ios install steps #1636

Closed vonovak closed 3 months ago

vonovak commented 4 months ago

Hi and thanks for maintaining this popular library!

This PR attempts to clear up the installation instructions for iOS.

The instructions currently say that a manual step is needed, but I haven't found it to be necessary. In fact, when I follow the "iOS Setup" I get an error Multiple commands produce '.../iconsdemo.app/FontAwesome6_Regular.ttf'

Only the last bullet point mentions that if you use autolinking (which almost everybody does), it will automatically add all fonts - so the manual adding of files to Xcode isn't needed.

Then there's this:

Note 2: If you're getting problems with duplicate outputs file for fonts on ios build, try running cd ios && pod install after the react-native.config.js configuration.

However, the correct approach would be to not "Navigate to node_modules/react-native-vector-icons and drag the Fonts folder (or select specific fonts) into your Xcode project." and "In Xcode, select your project in the navigator, choose your app's target, go to the Build Phases tab, and under Copy Bundle Resources, add the copied fonts." in the first place. The only necessary step is to add fonts to Info.plist.

Please feel free to organize the instructions differently, this is mostly me pointing out that there's potential for more clarity.

Thank you :)

vonovak commented 3 months ago

@johnf hello do you have some thoughts on this? 🙂 TY