search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.46k stars 2.13k forks source link

feat: improve new arch support #1652

Closed vonovak closed 2 months ago

vonovak commented 2 months ago

this PR

I still have a few changes to contribute, mostly on the JS side. TY! :)

johnf commented 2 months ago

@vonovak Can you check out the fix-tests branch. I've updated the detox tests to make sure they work again and am about to add new-arch support. Right now with old-arch they are failing on 0.72 which I suspect is related to the android changes

You can test by

cd packages/icon-explorer
./set-rn-version.sh 0.72
yarn start
yarn test:android

I'm seeing errors about VectorIcons not existing

vonovak commented 2 months ago

@johnf can you share what stacktrace / error you're seeing? TY

johnf commented 2 months ago

@vonovak 

BUNDLE  ./index.js 

 ERROR  Invariant Violation: TurboModuleRegistry.getEnforcing(...): 'VectorIcons' could not be found. Verify that a module by this name is registered in the native binary., js engine: hermes
 LOG  Running "IconExplorer" with {"rootTag":51}
 ERROR  Invariant Violation: "IconExplorer" has not been registered. This can happen if:
* Metro (the local dev server) is run from the wrong folder. Check if Metro is running, stop it and restart it in the current project.
* A module failed to load due to an error and `AppRegistry.registerComponent` wasn't called., js engine: hermes
vonovak commented 2 months ago

@johnf that's a little odd 🤔 . This name should correspond to this. It does correspond so I'll need to debug this a bit. However, this week I won't have availability so hopefully next.