oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.46k stars 2.13k forks source link

ITMS-90792: Invalid font (10.2.0) Issue persists #1662

Closed JordanAlexa closed 1 month ago

JordanAlexa commented 2 months ago

Environment

react-native-vector-icons 10.2.0 react-native 0.74.5

Description

I was under the impression that version 10.2.0 addressed this problem but unfortunately it's still rejecting my submissions, the latest rejection is clear:

_ITMS-90792: Invalid font - There was an error validating the font named 'FontAwesome6Free-Solid' at 'MY.app/assets/node_modules/@expo/vector-icons/build/vendor/react-native-vector-icons/Fonts/FontAwesome6Solid.ttf'. ‘glyf’ table instructions.

I tried to be thorough, I uninstalled the previous react-native-vector-icons, made sure the node_modules folder with this package was gone. I went to the ios/pods folder and removed it from there as well.

I ran npm install react-native-vector-icons@10.2.0 Afterwards I ran pod install from the ios directory Everything looked great in TestFlight and of course as you can see it failed.

What might I be doing wrong here? Any guidance is deeply appreciated 🆘 😅

johnf commented 2 months ago

@JordanAlexa Looks like you are using @expo/vector-icons so you are using it's version of FontAwesome6_Solid.ttf and not the one that comes from react-native-vector-icons.

JordanAlexa commented 2 months ago

@JordanAlexa Looks like you are using @expo/vector-icons so you are using it's version of FontAwesome6_Solid.ttf and not the one that comes from react-native-vector-icons.

Interesting -- so it seems like what I need to do is remove the references to FontAwesome6 from @expo/vector-icons then? I fear removing @expo/vector-icons entirely may not be the right course.

Or perhaps I just need to copy the .ttf file itself from the latest version of react-native-vector-icons into that vector-icons folder to replace the old one?

johnf commented 2 months ago

You should be either using react-native-vector-icons or @expo/vector-icons but not both.

johnf commented 2 months ago

Probably worth opening a bug on @expo/vector-icons as well as this bug will affect their users too

johnf commented 1 month ago

@JordanAlexa Let me know if tihs persists and I'll reopen