search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.46k stars 2.13k forks source link

Windows file name install error #1672

Closed darkseneca closed 4 weeks ago

darkseneca commented 1 month ago

Environment

Windows 11 Yarn @react-native-vector-icons/common@npm:^11.0.0-alpha.2 @react-native-vector-icons/octicons@npm:^19.11.0-alpha.32

Description

When trying to install octicons or fontawesome in any project this error is shown:

PS C:\Users\redactedfolder> yarn add @react-native-vector-icons/octicons ➤ YN0000: ┌ Resolution step ➤ YN0002: │ @react-native/babel-plugin-codegen@npm:0.75.4 doesn't provide @babel/preset-env (p43786), requested by @react-native/codegen ➤ YN0002: │ babel-plugin-transform-flow-enums@npm:0.0.2 doesn't provide @babel/core (p62fa5), requested by @babel/plugin-syntax-flow ➤ YN0002: │ react-native@npm:0.75.4 [2f2be] doesn't provide @babel/preset-env (pdf68b), requested by @react-native/codegen ➤ YN0000: │ Some peer dependencies are incorrectly met; run yarn explain peer-requirements for details, where is the six-letter p-prefixed code ➤ YN0000: └ Completed ➤ YN0000: ┌ Fetch step ➤ YN0000: └ Completed in 0s 168ms ➤ YN0000: ┌ Link step ➤ YN0001: │ Error: While persisting /C:/Users/redactedyarncache -> /C:/Users/redacted/node_modules/@react-native-vector-icons/octicons ENOENT: no such file or directory, open 'C:\Users\redacted\node_modules\@react-native-vector-icons\octicons\lib\commonjs\index.js""' ➤ YN0000: └ Completed in 0s 312ms ➤ YN0000: Failed with errors in 0s 809ms

Reproducible Demo

Occurs on any project. When installing with npm it is shown as an error instead:

PS C:\Users\redacted> npm install --save @react-native-vector-icons/fontawesome6 npm warn tar TAR_ENTRY_ERROR ENOENT: no such file or directory, open 'C:\Users\redacted\node_modules\@react-native-vector-icons\fontawesome6\lib\commonjs\index.js""' npm warn tar TAR_ENTRY_ERROR ENOENT: no such file or directory, open 'C:\Users\redacted\node_modules\@react-native-vector-icons\fontawesome6\lib\module\index.js""'

added 1 package, and audited 726 packages in 1s

50 packages are looking for funding run npm fund for details

found 0 vulnerabilities

johnf commented 4 weeks ago

@darkseneca Thanks for catching this. Fixed in https://github.com/oblador/react-native-vector-icons/commit/f3456f1627e0d9df047a21fe91256e2dda3013d5 an errant sed command was creating some extra files windows doesn't like