search

oblador / react-native-vector-icons

Customizable Icons for React Native with support for image source and full styling.
https://oblador.github.io/react-native-vector-icons/
MIT License
17.39k stars 2.12k forks source link

Does not work with higher values for char codes #783

Closed kinosang closed 4 months ago

kinosang commented 6 years ago

Some people use higher values for char codes in custom iconsets, for example, we have a icon font using block from \uf2001 to \uff223. But String.fromCharCode() does not work with them, change the method to String.fromCodePoint() can solve this problem.

https://github.com/oblador/react-native-vector-icons/blob/14be3c6f0570d607b57cc51d6bdb8c784f1cecc3/lib/create-icon-set.js#L63-L65

Convert all the decimal codes to chars before call createIconSet() works well, too.

mayconmesquita commented 5 years ago

+1

johnf commented 4 months ago

This was eventually implemented