search

oblarquez / paleofire

paleofire package
13 stars 2 forks source link

pretreatment.r improvement? #7

Closed wfinsinger closed 7 years ago

wfinsinger commented 7 years ago

Hi,

I wondered if rather than writing on Line 66: missingValuesIndex = c(which(count<0) , which(is.na(count)))

it wouldn't be easier to write: missingValuesIndex = which(vol == 0)

In the end the samples with missing values are those that weren't analysed, thus samples whose volume is equal to zero. With this one wouldn't need to specify NA or -999 for missing samples.

cheers,

walt

oblarquez commented 7 years ago

Yes that make sense! missingValuesIndex = c(which(count<0) , which(is.na(count))) is simply the raw translation from CharAnalysis, since most people will follow the xls templates from CharAnalysis I am afraid that they if still continue to input -999 it could result in errors, Maybe missingValuesIndex = c(which(count<0) , which(is.na(count)), which(vol==0)) is good but less elegant :)

rykelly commented 7 years ago

In case of duplicates (e.g. count<0 and vol==0), use union, or maybe better yet (more intuitive to me, at least): missingValuesIndex = which(count<0 | is.na(count) | vol==0)

oblarquez commented 7 years ago

missingValuesIndex = which(count<0 | is.na(count) | vol==0) đź‘Ť

wfinsinger commented 7 years ago

Hi guys,

Many thanks for the rapid feedback.

Best wishes,

walt

On 10 Nov 2016, at 21:54, Olivier Blarquez notifications@github.com wrote:

missingValuesIndex = which(count<0 | is.na(count) | vol==0) đź‘Ť

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/oblarquez/paleofire/issues/7#issuecomment-259804644, or mute the thread https://github.com/notifications/unsubscribe-auth/AHH7ZpvQ8DpsqX9i1yO1E_bekN4tgiz2ks5q84SMgaJpZM4KvHB2.

Walter Finsinger Palaeoecology - ISE-M (UMR 5554 CNRS) Université de Montpellier 2 place Eugène Bataillon - CC065 (bat. 22) 34095 Montpellier Cedex 5 France

Tel: +33 (0)4 67 14 32 70 Mail: walter.finsinger@um2.fr http://freewheelinpalaeoecologist.wordpress.com/