search

oblarquez / paleofire

paleofire package
13 stars 2 forks source link

Return more information from pretreatment() #8

Closed iago-lito closed 2 years ago

iago-lito commented 2 years ago

Hello @oblarquez,

@wfinsinger uses the pretreatment() function of PaleoFire in their package PaleoAnomalies, but they need that more information be returned, which requires this minor modification of the return statement.

The current situation is that a slightly modified copy of pretreatment() lives in PaleoAnomalies repo (there). This is unsatisfactory because PaleoFire is not acknowledged as a formal dependency of PaleoAnomalies, and because future updates to PaleoFire will not automatically propagate to PaleoAnomalies.

As the current compiler of PaleoAnomalies, I suggest that this modification be made here instead, in PaleoFire official repo. All you have to do is to accept this PR, then run your tests to check that nothing is broken by this slight extension of the list returned (I would be suprised if anything did). Then I'll be able to declare paleofire::pretreatment() a formal dependency of PaleoAnomalies.

iago-lito commented 2 years ago

Great, thank you for reacting this quick :)