obmarg / graphql-ws-client

A GraphQL over Websockets implementation for Rust
Apache License 2.0
39 stars 15 forks source link

refactor: maintainability improvements #114

Closed carlocorradini closed 4 months ago

carlocorradini commented 5 months ago

This PR makes a few changes to the repository to make it easier to manage and/or utilize generally:

Changes

Let me know what you think πŸ€—πŸ₯³πŸ€―

obmarg commented 5 months ago

Thanks @carlocorradini but you really should have checked before going to the effort of putting this together.

I don't have the time to reply to each individual change just now, but most of these changes are not things I want.

carlocorradini commented 5 months ago

@obmarg Don't worry πŸ€— It didn't take me that much πŸ™Œ Tell me what you don't like/want and I'll refactor the PR πŸ˜ŠπŸ‘Œ

carlocorradini commented 4 months ago

Sorry for the late reply; I'll fix them as soon as possible.

carlocorradini commented 4 months ago

.gitattributes file is a common one that I use in all my projects and comes from the gitattributes repository. The file is very useful to have a common/shared knowledge of line terminator to avoid possible commit changes across different environments (Widnows, Apple, Linux, ...)

carlocorradini commented 4 months ago

Cargo.lock should NOT be committed. See official issue. Moreover, when you create a new library project the .gitignore file already contains Cargo.lock with a comment that it should be ignored if this is a library whereas maintained if this is a binary.

carlocorradini commented 4 months ago

For all markdown files I've fixed some blanks that have been left and checked the formatting/styling with markdownlint (i.e. added a blank between a title and text). Moreover, fixed NewIssue in CONTRIBUTING.md

obmarg commented 4 months ago

Cargo.lock should NOT be committed. See official issue. Moreover, when you create a new library project the .gitignore file already contains Cargo.lock with a comment that it should be ignored if this is a library whereas maintained if this is a binary.

First off - it doesn't really matter what a cargo issue from 2014 says. It's my project and I want to commit Cargo.lock.

Secondly, this has not been the official stance for coming up to a year.

Third, that is not the behaviour for a new library project:

CleanShot 2024-06-18 at 11 37 19@2x

carlocorradini commented 4 months ago

@obmarg Awesome πŸ₯³ I didn't know about that blog post πŸ€—

carlocorradini commented 4 months ago

@obmarg Everything should be fixed now πŸ€—πŸ₯³

carlocorradini commented 4 months ago

@obmarg Done 😊

carlocorradini commented 4 months ago

Done πŸ‘