Closed carlocorradini closed 4 months ago
Thanks @carlocorradini but you really should have checked before going to the effort of putting this together.
I don't have the time to reply to each individual change just now, but most of these changes are not things I want.
@obmarg Don't worry π€ It didn't take me that much π Tell me what you don't like/want and I'll refactor the PR ππ
Sorry for the late reply; I'll fix them as soon as possible.
.gitattributes
file is a common one that I use in all my projects and comes from the gitattributes repository.
The file is very useful to have a common/shared knowledge of line terminator to avoid possible commit changes across different environments (Widnows, Apple, Linux, ...)
Cargo.lock
should NOT be committed.
See official issue.
Moreover, when you create a new library project the .gitignore
file already contains Cargo.lock
with a comment that it should be ignored if this is a library whereas maintained if this is a binary.
For all markdown files I've fixed some blanks that have been left and checked the formatting/styling with markdownlint (i.e. added a blank between a title and text). Moreover, fixed NewIssue
in CONTRIBUTING.md
Cargo.lock
should NOT be committed. See official issue. Moreover, when you create a new library project the.gitignore
file already containsCargo.lock
with a comment that it should be ignored if this is a library whereas maintained if this is a binary.
First off - it doesn't really matter what a cargo issue from 2014 says. It's my project and I want to commit Cargo.lock
.
Secondly, this has not been the official stance for coming up to a year.
Third, that is not the behaviour for a new library project:
@obmarg Awesome π₯³ I didn't know about that blog post π€
@obmarg Everything should be fixed now π€π₯³
@obmarg Done π
Done π
This PR makes a few changes to the repository to make it easier to manage and/or utilize generally:
Changes
.github/workflows
)lints
inCargo.toml
Some code has been refactored (no breaking changes) to fix all lints.gitignore
Cargo.lock
should be ignored in libraries (added in.gitignore
)README.md
(all*.md
files in general) with better badges.Let me know what you think π€π₯³π€―