obmarg / graphql-ws-client

A GraphQL over Websockets implementation for Rust
Apache License 2.0
39 stars 15 forks source link

refactor: remove unused `payload` field from enum #119

Open hamirmahal opened 2 months ago

hamirmahal commented 2 months ago

closes #118.

obmarg commented 2 months ago

Thanks for the contribution @hamirmahal - I'm not sure that removing those fields is the right fix though. Potentially should be exposing those fields to the user somehow rather than just removing them...

At the very least that's the case for the ConnectionAck one - and maybe the ping/pong ones as well (although I can see less obvious use cases for those ones).