search

obmarg / graphql-ws-client

A GraphQL over Websockets implementation for Rust
Apache License 2.0
39 stars 15 forks source link

release: v0.9.0 #92

Closed graphql-ws-client-releaser[bot] closed 5 months ago

graphql-ws-client-releaser[bot] commented 5 months ago

🤖 New release

Changelog

## v0.8.3 - 2024-06-08 ### New Features - send periodic pings for keep alives ([#103](https://github.com/obmarg/graphql-ws-client/pull/103)) - impl debug for client ([#101](https://github.com/obmarg/graphql-ws-client/pull/101)) - add keep-alive capability ([#93](https://github.com/obmarg/graphql-ws-client/pull/93)) ### Bug Fixes - swap no-logging feature for logging feature ([#97](https://github.com/obmarg/graphql-ws-client/pull/97)) ### Changes - Fix compilation error in actor mod ([#96](https://github.com/obmarg/graphql-ws-client/pull/96)) - release-plz config tweaks ([#95](https://github.com/obmarg/graphql-ws-client/pull/95)) - simplify keep alive implementation ([#94](https://github.com/obmarg/graphql-ws-client/pull/94)) - pin release-plz version ([#91](https://github.com/obmarg/graphql-ws-client/pull/91))

This PR was generated with release-plz.

rhishikeshj commented 5 months ago

@obmarg it's weird that the CI action which uses cargo build --all-features works but cargo build does not

â–¶ cargo build --all-features
    Finished dev [unoptimized + debuginfo] target(s) in 0.23s

â–¶ cargo build
   Compiling graphql-ws-client v0.8.2 (/Users/rhishikeshj/workspace/juxt/artis/src/graphql-ws-client)
error[E0425]: cannot find value `keep_alive_duration` in this scope
   --> src/next/actor.rs:173:29
    |
173 | ...                   keep_alive_duration
    |                       ^^^^^^^^^^^^^^^^^^^
    |
help: you might have meant to use the available field
    |
173 |                             self.keep_alive_duration
    |                             +++++

For more information about this error, try `rustc --explain E0425`.
error: could not compile `graphql-ws-client` (lib) due to 1 previous error
obmarg commented 5 months ago

@rhishikeshj yeah, I think it's because the no-logger feature disables logging, so --all-features was (counterintuitively) removing code.

I want to rethink that, in retrospect it was not a good idea.