search

obmarg / kazan

Kubernetes API client for Elixir
https://hex.pm/packages/kazan
MIT License
140 stars 35 forks source link

Add support for watch requests #14

Closed chazsconi closed 6 years ago

chazsconi commented 6 years ago

Resolves #12

obmarg commented 6 years ago

Nice one @chazsconi - thanks for the contribution. Have a few comments & questions though, which I'll make sometime soon.

obmarg commented 6 years ago

Could you add a simple integration test of this watch functionality please? (in the test/integration_test.exs file) Maybe something that watches pods & then creates, updates & deletes it.

I guess I haven't added instructions for running the integration tests, but it should be fairly simple. Make sure you have a kube cluster set up & a kube config file for it, then set the KUBECONFIG environment variable to point at that file, and run the integration tests. Something like this:

export KUBECONFIG=whatever
mix test --only integration
chazsconi commented 6 years ago

Now that K8S 1.8.8 has been released with https://github.com/kubernetes/kubernetes/pull/58547 fixed, I will get this finished.

chazsconi commented 6 years ago

Actually I'll wait until #30 is merged otherwise there'll be quite a few conflicts.

chazsconi commented 6 years ago

Now updated and rebased against master

chazsconi commented 6 years ago

Agreed - capture_log: false is not required. I've removed it.

obmarg commented 6 years ago

Awesome, excited to finally get this merged.

chazsconi commented 6 years ago

Thanks for merging!