Closed RootShinobi closed 3 months ago
i’ll try and look into it in a little bit
On Tue, May 28, 2024 at 16:37, RootShinobi @.***(mailto:On Tue, May 28, 2024 at 16:37, RootShinobi < wrote:
AsyncClient.init() got an unexpected keyword argument 'proton'
— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you are subscribed to this thread.Message ID: @.***>
i think kwargs not for AsyncClient
it is because of changes i made, it needs to kwargs.pop somewhere or use an alternative to kwargs
look what i found. u can use init kwargs as kwargs for the httpx client
btw the structure of the client is very very strange
core issue is that you must be passing proton kwarg to asyncAuthenticate not init
edit: largely the codebase is designed by trevor not me, many designs decisions are very poor but i cant be bothered to do a full refactor, a lot of decisions are made due to each function being async and init being unable to be ran asynchronously
core issue is that you must be passing proton kwarg to asyncAuthenticate not init
I do it
I mean, perhaps it is better to accept the parameters for AsyncClient in the init of AsyncAccount? and leave kwargs of asyncAuthenticate for another
there i added a patch to pop proton in asyncLogin
AsyncClient.init() got an unexpected keyword argument 'proton'