search

obonaventure / cnp3

Computer Networking : Principles, Protocols and Practice (first and second edition, third edition is being written on https://github.com/cnp3/ebook)
https://www.computer-networking.info
503 stars 91 forks source link

Missing figures introduced in the second edition #190

Closed sCreami closed 8 years ago

sCreami commented 8 years ago

Upon building from scratch, I realised that the old Makefile-images forgets to build the new figures introduced in the transport chapter. Update Makefile-images to fix this. Add a new rule to Makefile figures to call Makefile-images from it. Update Vagrantfile to run one single instance of apt-get install, this slightly speed up the configuration of the vagrant box. The duplication of install inkscape has also been removed.

obonaventure commented 8 years ago

Thanks

sCreami commented 8 years ago

Building files from scratch has now been made easier. An user just need to type the following to build the desired version.

make figures make html or latexpdf

The html build works perfectly, however I'm concerned over latexpdf. Make exits with an error code has seen here screen shot 2015-11-20 at 15 49 20

It still produces the pdf [10MB] as you can see here : http://axn.io/cnp3/CNP3.pdf The log file can be found here : http://axn.io/cnp3/CNP3.log.txt All the other auxiliary files can be found in the parent directory : http://axn.io/cnp3/

I'm concerned because all I can see in the log files are warnings, not one error. This is not supposed to exit this way but I can't find why it does.

sCreami commented 8 years ago

Solved. This will be the matter of a future pull request.