search

obophenotype / bds-pipeline-config

Brain data standards ontologies building pipeline configuration
1 stars 1 forks source link

Add more node labels to Neo config #5

Closed dosumis closed 3 years ago

dosumis commented 3 years ago

We should have Neo:labels for:

(leave out marker-based for now)

shawntanzk commented 3 years ago

@dosumis Added nodes I think are relevant, wonder if we do a BDS_subset that aren't neuronal - not sure how to write that in

@hkir-dev not sure if this needs to be merged somewhere or it's reading straight from the branch but tagging you in case this needs to be merged somewhere, in which case could you help me with that please? Thanks! https://github.com/obophenotype/bds-pipeline-config/blob/neo4jowl-config-edit/config/prod/neo4j2owl-config.yaml

hkir-dev commented 3 years ago

@shawntanzk we have an indentation problem at line 50. Can we check please?

hkir-dev commented 3 years ago

also couldn't found some of the entities (such as CL:4023012 and CL:4023038) in bdscratch-full.owl. So it crashes (I think)

shawntanzk commented 3 years ago

@shawntanzk we have an indentation problem at line 50. Can we check please?

@hkir-dev whoops sorry, fixed it

also couldn't found some of the entities (such as CL:4023012 and CL:4023038) in bdscratch-full.owl. So it crashes (I think)

Oh yeah, that's what I was worried about, those are newly added terms to CL-edit. I assume bdscratch-full.owl takes gets the CL terms from the current released CL @dosumis can we do a CL release for this? alternatively I guess we can comment all the CL that aren't there yet for now?

shawntanzk commented 3 years ago

Added with work on branch done with #7 see branch https://github.com/obophenotype/bds-pipeline-config/blob/add-BDSHELPexemplar_of-some/config/prod/neo4j2owl-config.yaml