search

obophenotype / bio-attribute-ontology

source files for OBA (Ontology of Biological Attributes)
https://obophenotype.github.io/bio-attribute-ontology
Creative Commons Zero v1.0 Universal
27 stars 11 forks source link

Create ratio_location.yaml #273

Closed ar-ibrahim closed 3 months ago

ar-ibrahim commented 1 year ago
ar-ibrahim commented 1 year ago

@rays22 This is the suggested change to the name of the pattern, 'proportion_of_attributes', based on the PATO class 'proportionality_to'. I also created a tsv file for the pattern and generated a term as an example. I still think we may need to create an additional pattern where the variables are'attribute1, attribute2, location'. This is to avoid creating a large number of new terms. For example if we want to create the ratio 'sputum sodium to sputum potassium ratio' we would need to create those two terms first. That would not be necessary if the variables include the location.

ar-ibrahim commented 12 months ago

I have consulted @rays22 about the recurring QC warnings and as per my understanding this has been an outstanding issue that does not prevent merging the PR should the suggested changes be approved.