obophenotype / bio-attribute-ontology

source files for OBA (Ontology of Biological Attributes)
https://obophenotype.github.io/bio-attribute-ontology
Creative Commons Zero v1.0 Universal
27 stars 11 forks source link

Added new 'response to chemical' term for GWAS #275

Closed ar-ibrahim closed 11 months ago

ar-ibrahim commented 11 months ago
ar-ibrahim commented 11 months ago

@rays22 After updating the chebi slim and importing the chebi term for the new term request, there's a new QC error unrelated to my issue:

ERROR   misused_obsolete_label  OBA:0006023 rdfs:label  obsolete proline oxidase activity rate
ERROR   misused_obsolete_label  OBA:1000857 rdfs:label  obsolete proline oxidase activity quality

What are your thoughts on this?

rays22 commented 11 months ago
ERROR misused_obsolete_label  OBA:0006023 rdfs:label  obsolete proline oxidase activity rate
ERROR misused_obsolete_label  OBA:1000857 rdfs:label  obsolete proline oxidase activity quality

@ar-ibrahim , In cases like this, when the GO term component becomes obsolete, you need to find an appropriate replacement, or do a manual term edit in Protege. In the present case, there is a replacement suggested by GO for GO:0051699: GO:0004657 proline dehydrogenase activity. Replace the occurrences of GO:0051699 with GO:0004657 in entity_attribute.tsv.

rays22 commented 11 months ago
  • does the orcid ID represent the creators of the pattern or the term?

It is the ORCID of the contributor of the term.