Fix or improve labels - Githubissues

obophenotype / bio-attribute-ontology

source files for OBA (Ontology of Biological Attributes)

https://obophenotype.github.io/bio-attribute-ontology

Creative Commons Zero v1.0 Universal

27 stars 11 forks source link

Fix or improve labels #295

Closed rays22 closed 11 months ago

rays22 commented 11 months ago

If applied, this commit will fix #276 .

rays22 commented 11 months ago

LGTM but I would ask in OBO channel what people think of the changing "X attribute" labels to "X characteristic" labels. This gives @cmungall and @dosumis a chance to but in (this is not a minor change)

I am open to suggestions and input on the labels, but I am not sure if this label change is a major change. I would think that attribute and characteristic are synonyms.:

characteristic: a typical or noticeable quality of someone or something
attribute: a quality or characteristic that someone or something has

matentzn commented 11 months ago

Its also about branding. better safe than sorry

jamesamcl commented 11 months ago

Maybe some polling required. I feel that “characteristic” is a more commonly used word in the biology domain while “attribute” is more computer science - but I don’t have any data to back this up.

rays22 commented 11 months ago

I have reverted the characteristic in the labels to attribute. We can come back and change the labels in another PR, but now I want to merge this one, because it fixes some typos for a new OBA release.